-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSR-7 Compliance #20
Comments
Yeah I like this idea - I hadn't thought of going down that route. I'd be really happy to see your ideas on how it could work! |
👍 @DaGhostman Maybe this can be added to Phroute v3? The current PSR-7 is in review again, so it will take some time before there will be actual libraries that have full and stable support for it. Therefore, there is no need to rush with this. And I think dispatchPSR is fugly indeed and not necessary if we just bump the major version number one up. |
@frederikbosch Yeah, you are right. It seems that quite some time will pass until the PSR gets accepted. |
@DaGhostman There is already a router supporting PSR-7. Maybe it is not a bad idea after all to work on this. |
Would a PSR-7 request be appropriate?
I think, that having a PSR-7 compliant method will make it easier for implementing #5 Sub-domain routing as PSR-7 server request object should contain all the necessary information for the dispatcher to do its work?
I was thinking of making a PR for a method dispatchPSR (although it looks fugly..) so that such implementation does not break existing implementations using Phroute.
The text was updated successfully, but these errors were encountered: