Do not try to detach detached thread, the result is undefined. Fixes …

…issue pupnp#102 (cherry picked from commit 386b7ed)
mrjimenez · Jan 27, 2019 · 04b454f · 04b454f
1 parent 0b07957
commit 04b454f
Showing 1 changed file with 0 additions and 5 deletions.
diff --git a/upnp/src/threadutil/ThreadPool.c b/upnp/src/threadutil/ThreadPool.c
@@ -651,11 +651,6 @@ static int CreateWorker(
 	rc = ithread_create(&temp, &attr, WorkerThread, tp);
 	ithread_attr_destroy(&attr);
 	if (rc == 0) {
-		rc = ithread_detach(temp);
-		/* ithread_detach will return EINVAL if thread has been
-		 successfully detached by ithread_create */
-		if (rc == EINVAL)
-			rc = 0;
 		tp->pendingWorkerThreadStart = 1;
 		/* wait until the new worker thread starts */
 		while (tp->pendingWorkerThreadStart) {