[META] Where do our libraries live?

[mrjmd]

As of this moment, React and Angular 2 are both included in our code base, inside their framework sub-modules under assets/vendor directories.

This is unsustainable for multiple reasons, and we need to figure out how these libraries will be included in projects.

[mark-casias]

Started refactoring these into npm package.json files. the node_modules layout is a little bit different than what we have put into our repo and I am not sure which packages to reference on a few. We'll talk about this on Tuesday (training all day Monday). See my branch 'features/markie/8-packaging'

[mark-casias]

and then there's this: https://www.drupal.org/developing/api/8/assets#external

angular.angularjs:
remote: https://github.com/angular/angular.js
version: 1.4.4
license:
name: MIT
url: https://github.com/angular/angular.js/blob/master/LICENSE
gpl-compatible: true
js:
https://ajax.googleapis.com/ajax/libs/angularjs/1.4.4/angular.min.js: { type: external, minified: true }

[mrjmd]

Can you PR your branch with progress on this just so we can see the diff?

[mark-casias]

PR: #18 for your mocking goodness.

[mrjmd]

On further consideration I think loading externally in our libraries might be the perfect way to handle this, at least for our POC. It will allow us to keep the libraries out of the filesystem without adding additional dependencies.

In any case, the PR above needs latest merged into it.

[mark-casias]

This can probably be closed per PR: #31 or we can continue the discussion. Both the react and NG2 libraries load from the externals.

[mrjmd]

For pdb_ng2 at least, I've accepted the value in an npm dependency (both the upgrade to RC1 and the latest developments on #52 pushed me in this direction). As such, I've moved most of the library sources to use node_module locations.

Ultimately I think where our libraries live will be a framework-level decision, for which individual tickets can be opened. Closing this.