-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: Joi should be in the peerDependencies section #27
Comments
It will probably mean that this library should have more tests using multiple versions of joi |
I was thinking about this briefly as well a few days ago when I was trying this package out. The project I was working on had a dependency to a package, lets call it A, and this package A was using version When I added And the reason for this is because I always ended up in this if statement below:
Since this package is using methods like |
@hazmah0 that sounds like another issue, this library has only been tested with joi version 17 and greater. |
sorry I didn't finish reading your comment you explained the issues I found with versions of joi less than 17 |
This has now been completed https://github.com/mrjono1/joi-to-typescript/releases/tag/3.0.0 |
I'm pretty sure that Joi should be a peer dependency instead of a normal dependency.
I haven't had a use case like this before so I will investigate if this is the case I may do a major version bump for this change.
The text was updated successfully, but these errors were encountered: