Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duration argument in slackr_history() is not respected if posted_from_time is not specified #181

Closed
czeildi opened this issue Feb 8, 2023 · 1 comment · Fixed by #182
Assignees
Labels

Comments

@czeildi
Copy link
Contributor

czeildi commented Feb 8, 2023

In slackr_history() the duration argument has no effect in contrast with the documentation if posted_from_time is not specified (which is the default).

I think the problem is in this line:
https://github.com/mrkaye97/slackr/blob/master/R/slackr_history.R#L34 Instead of missing(posted_from_time) it should check if the posted_to_time is provided as the code and logic relies on that. The functions works as expected if I specify duration = "whatever dummy value"

Also I think the documentation could be improved as the default is not 24 hours, but no limit on the duration.
https://github.com/mrkaye97/slackr/blob/master/R/slackr_history.R#L13

I am happy to prepare a PR if you are open to it.

@mrkaye97
Copy link
Owner

hey @czeildi, thanks for the detailed bug report! sure thing, if you're up for putting in a fix I'd be happy to review it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants