You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In slackr_history() the duration argument has no effect in contrast with the documentation if posted_from_time is not specified (which is the default).
I think the problem is in this line: https://github.com/mrkaye97/slackr/blob/master/R/slackr_history.R#L34 Instead of missing(posted_from_time) it should check if the posted_to_time is provided as the code and logic relies on that. The functions works as expected if I specify duration = "whatever dummy value"
In
slackr_history()
theduration
argument has no effect in contrast with the documentation ifposted_from_time
is not specified (which is the default).I think the problem is in this line:
https://github.com/mrkaye97/slackr/blob/master/R/slackr_history.R#L34 Instead of
missing(posted_from_time)
it should check if theposted_to_time
is provided as the code and logic relies on that. The functions works as expected if I specifyduration = "whatever dummy value"
Also I think the documentation could be improved as the default is not 24 hours, but no limit on the duration.
https://github.com/mrkaye97/slackr/blob/master/R/slackr_history.R#L13
I am happy to prepare a PR if you are open to it.
The text was updated successfully, but these errors were encountered: