Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving PNG - Minutor.exe stopped working #60

Closed
eyekanspele opened this issue Dec 24, 2014 · 11 comments
Closed

Saving PNG - Minutor.exe stopped working #60

eyekanspele opened this issue Dec 24, 2014 · 11 comments

Comments

@eyekanspele
Copy link

When trying to load my vanilla SMP world files in minutor works no problem as expected. However when I go to save the world as a PNG; it lets me chose a directory and file to save the png, however when I go to save right away I am given a windows error screen that "Minutor has stopped working".

This is happening to me with both the installed and non-installed versions of version 2.0.1.

I am using a x64 version of Windows 8.1 with an intel based cpu.

@EtlamGit
Copy link
Collaborator

I'm using "Save world to PNG" really often, but I never get crashes... (but I have Windows 7 64bit).

  • Do you have an extremely large world? (My worlds are typically smaller ~300MB.)
  • Are you low on free memory in your PC? (Minutor 2.0.1 is still limited to 2GB, but this changed in the latest development version.)
  • Do you have write permission in the folder you try to write the PNG to?

Could you please do a test:

  • Reduce Chunk loading distance in Minecraft
  • Start a new world with Seed="Saving PNG", enter it and leave right afterwards
  • Load this world in Minutor
  • Click File->SavePNG, type test.png and click SAVE

If this also crashes, could you test with other Windows versions?

@eyekanspele
Copy link
Author

The world files I am using is nearing 600mb. Maybe this is the problem?

The computers I tried both had 16gb of memory. Should I try with a computer with more?
I tried with a computer running Windows 8.1 x64 and another with Windows 7 x64

Yes, there are sufficient write permissions.

I did try to make a new 1.8.1 server and was able to generate a new set of world files and was able to generate a png just fine with these files (10mb).

I am assuming it is the large set of world files causing problems. I am going to try to use a world editior and get rid of some chunks to see if I can slim out my world files.

@eyekanspele
Copy link
Author

I figured out the issue. There were duplicate region files (.mca) that seemed to be generated from a world editor program; either the duplicate region files or that there were misnamed region files that were not actually part of the world.

There were no issues when minutor opened the world files.

@EtlamGit
Copy link
Collaborator

Glad that you found the root of this problem!
Could you provide the exact file names that caused the error? Or the tool that generated them? Maybe it is possible to add some checks to get Minutor more robust to files generated by other Minecraft related tools.

(And NO, the size of the map should not be an issue for Minutor. Sean has implemented a really nice world save algorithm, working only on parts of the world at the same time.)

@eyekanspele
Copy link
Author

I am not sure which editor caused the problems. Others that work on the server tried a handful of editing tools; I am not sure which tools they all used.

the duplicate .mca files were labelled as "r.-1.0 (copy 2014-12-11).mca" which I am assuming was a duplicate copy of "r.-.1.0.mca" which was causing a problem... there was a second .mca duplication like this.

Could a regex filter to only use files names that match a pattern of "\r.(-?\d+).(-?\d+).mca/" ?

@george-tsiros
Copy link

getting what i think is a null deref when i click the menu item. windows 10, amd64, latest minutor release from github releases (5 days ago)?

Exception thrown at 0x00007FF7636915E0 in minutor.exe: 0xC0000005: Access violation reading location 0x0000000000000000.

which of course means little, there's no debugging information as far as i can see and i fear building it requires qt which is a massive headache in and of itself (did you really have to use qt...?) . The entirety of the world folder is 128MiB. It's a 1.17.1 world.

strangely enough, when i try to save a snapshot world, it works ok?

@EtlamGit
Copy link
Collaborator

PNG save "should" work with Minecraft 1.17.1 (I am using it).

Please try to find a way to upload your world so we can start debugging.

@george-tsiros
Copy link

george-tsiros commented Oct 31, 2021

torrent ok?

New_World.zip

The .7z inside is the entirety of the folder. For your convenience, either download only the .7z or only the rest of the files.

I am sorry I could not find a way to do a magnet link. In the meantime i will try with a new blank 1.17.1 world see what it does

edit: do you think optifine may be at fault?

@george-tsiros
Copy link

DON'T bother with THAT torrent, it seems a completely new 1.17.1 world also fails. So it is not something with the world, should be something with my pc. Please contact me somehow.

@EtlamGit
Copy link
Collaborator

I noticed some empty region files in your world. This was a bug with 1.17.

There is already a patch for this issue: de9c637 that will be released together with the 1.18 update.

You can test that with a development preview build.

@george-tsiros
Copy link

ooooh!

you're good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants