Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newlines in header values silently break everything #54

Closed
ethercrow opened this issue Nov 15, 2018 · 2 comments
Closed

Newlines in header values silently break everything #54

ethercrow opened this issue Nov 15, 2018 · 2 comments
Labels

Comments

@ethercrow
Copy link

When I have a header option like

header "Authorization" ("Bearer " <> mytoken)

and mytoken ends with a newline (got from external process and forgot to strip it) then the newline is inserted in the middle of headers, thus making some headers part of the body and sending you on a debugging trip.

For example, python requests library checks headers and rejects inappropriate headers before actually sending a request.

@mrkkrp mrkkrp added the bug label Nov 15, 2018
@mrkkrp
Copy link
Owner

mrkkrp commented Nov 15, 2018

Actually it looks like a bug in http-client to me. Could you try reporting this there too? I think that http-client should perform this check.

@mrkkrp
Copy link
Owner

mrkkrp commented Nov 20, 2018

Seems to be resolved upstream, closing.

@mrkkrp mrkkrp closed this as completed Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants