Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration request from IBusConfig to GSettings #12

Closed
fujiwarat opened this issue Dec 21, 2017 · 10 comments
Closed

Migration request from IBusConfig to GSettings #12

fujiwarat opened this issue Dec 21, 2017 · 10 comments
Assignees

Comments

@fujiwarat
Copy link

I'm the maintainer of IBus.
ibus-unikey uses IBusConfig and I'd ask to migrate it to GSettings and delete IBusConfig.

E.g. setup/config_utils.cpp

void read_config(void *data, UnikeyMainSetupOptions* opt)
{
    GSettings *settings_inputmethod = g_settings_new ("org.freedesktop.ibus.engine.unikey");
    if (ibus_unikey_config_get_string (settings, CONFIG_INPUTMETHOD, &str)) {
    }


...

goolean ibus_uinkey_config_get_string (GSettings *settings,
                                                                const gchar *key,
                                                                gchar** result)
{
    GVariant *value = NULL;
    value = g_settings_get_value (settings, key);
    if (value) {
        *result = g_variant_dup_string (value, NULL);
        g_variant_unref (value);
        return true;
    }
    return false;
}

https://groups.google.com/forum/#!topic/ibus-devel/Mu1IoFX-bKE

@tulequ
Copy link
Collaborator

tulequ commented Dec 28, 2017

Thank you, I will do it when have free time
Maybe this weekend :)

@fujiwarat
Copy link
Author

Thank you!

@fujiwarat
Copy link
Author

Do you have any updates?

@tulequ
Copy link
Collaborator

tulequ commented Jun 18, 2018

I will try to do it soon, do you have any schedule for the next version?

@fujiwarat
Copy link
Author

I have the plan to release 1.6 after the major IMEs migrate to GSettings.
The current status is here:
https://github.com/ibus/ibus/wiki/GSettingsMigration
Some important IMEs do finish the migration yet.

I don't think the status of ibus-unikey prevents ibus 1.6 but it would be great if you could migrate and I'd ask the current status.

@tulequ tulequ self-assigned this Jul 8, 2018
@tulequ
Copy link
Collaborator

tulequ commented Jul 8, 2018

Currently, I had done it (locally), you can consider this issue is closed
Now, I just want to refactor/change a lot of things (the code is nearly ten years ago)
So it will take a little time to release new version

@fujiwarat
Copy link
Author

Thank you. I'd like to see the changes. Currently setup/dlg_main_setup.cpp uses IBusConfig at least in git master.

@tulequ
Copy link
Collaborator

tulequ commented Jul 10, 2018

I just push it to dev branch, just check there

@fujiwarat
Copy link
Author

Thank you.
04e7c91

@fujiwarat
Copy link
Author

fujiwarat commented Jul 11, 2018

Commented on:
ae9319c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants