Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you user the same image flags file from the plugin #15

Closed
oliveiraped opened this issue Sep 21, 2015 · 2 comments · Fixed by #44
Closed

Can you user the same image flags file from the plugin #15

oliveiraped opened this issue Sep 21, 2015 · 2 comments · Fixed by #44
Assignees

Comments

@oliveiraped
Copy link

Can you user the same image flags file from the plugin

https://github.com/Bluefieldscom/intl-tel-input

Please check this issue about retina display
jackocnr/intl-tel-input#299

@mrmarkfrench
Copy link
Owner

I will take a look at what would be required to update to use the newer flag images adopted by the plugin this one is based on.

I suspect it will be very possible, though time-consuming, to update to the newer image and adjust the CSS to match accordingly. This should give this plugin a better set of flags for use on a retina display.

However, I think it unlikely that we'll be able to let you easily load only a single image file for both plugins. Although many people (including myself) use both plugins, they are each designed to work on their own, and neither should require the other be installed in order to work. The side-effect is that each needs to provide its own image file. This also prevents changes to the image file used in one plugin breaking the display of flags in the other.

@humrochagf
Copy link
Contributor

humrochagf commented May 17, 2017

i also fixed this issue, but is on a branch of my fork, after finishing with the #33 issue i will make another to fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants