Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Go to definition" and "rename" do not work properly #175

Closed
OliverJAsh opened this issue Nov 30, 2022 · 4 comments
Closed

"Go to definition" and "rename" do not work properly #175

OliverJAsh opened this issue Nov 30, 2022 · 4 comments

Comments

@OliverJAsh
Copy link

OliverJAsh commented Nov 30, 2022

Describe the bug
"Go to definition" and "rename" do not work properly

To Reproduce
Steps to reproduce the behavior:

  1. Open a TS file
  2. "Go to definition" on a class name, or try to rename it using "rename symbol"

Expected behavior
The operation is successful.

Screenshots

The CSS file is opened/changed but in the wrong location.

Screen.Recording.2022-11-27.at.11.24.36.mov
@mrmckeb
Copy link
Owner

mrmckeb commented Dec 4, 2022

This hasn't been released yet, sorry! It should be today.

@mrmckeb mrmckeb closed this as completed Dec 4, 2022
@OliverJAsh
Copy link
Author

Thanks. Go to definition is working now but rename is still broken for some reason.

Screen.Recording.2022-12-05.at.11.05.52.mov

@musjj
Copy link

musjj commented Mar 13, 2024

It's still broken. The definition jump for *.scss files seems also complete wrong on my end. Can this issue be re-opened?

@mrmckeb
Copy link
Owner

mrmckeb commented Mar 21, 2024

Hi @musjj, can you please open a new issue with a reproduction?

Rename won't work, but go to definition partially works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants