-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Results box hides content #42
Comments
I'm open to a PR for sure! It's not my repo, but FWIW 👍. I think the idea of a toggle (with like an X in the upper corner of the div-thingy) sounds nice, but making it draggable is cool too. Another idea I had was to make it switch to the top when you scrolled down within X% of the the bottom of the page, but I'm concerned that it'll be jerky and that introducing an event listener on the That brings up something else to consider: Keeping this in vanilla JS and not introducing dependencies is probably the best bet to avoiding unforeseen issues. Again, there's no telling what is on the page when you inject this JS. @mrmrs what do you think? You tweeted you had some ideas...? |
+1 |
@winkerVSbecks @bradleyflood Check the update I just pushed. Always off, hold control to see the banner. I think it's a pretty clean solution. |
awesome 👍 |
The results box –
div
with idpesticide-for-chrome-result
– overlays on top of the site content. This makes it impossible to debug things that are in that part of the window.The text was updated successfully, but these errors were encountered: