Use flag instead of getattr as it was not working as expected. Provid… #14
Conversation
…ed raw pages instead of recursive call to har_parser.pages which reached the recursion limit on failure
|
Not sure how the coverage decreased since I didn't touch anything except for some local variables and the way pages were accessed in an Error |
|
LOL, yes coveralls can be janky, don't worry about it 😄 |
| 'No page found with id {0}\n\nValid pages are {1}'.format( | ||
| self.page_id, self.parser.pages) | ||
| 'No page found with id {0}\n\nPages are {1}'.format( | ||
| self.page_id, raw_data['pages']) |
There was a problem hiding this comment.
What would you think about just printing the page ID's here instead of the full pages dict? This output could probably get pretty confusing for a file with lots of HAR pages.
There was a problem hiding this comment.
Yeah that could work, I went with the closest thing to accessing the property .pages. I think the id's would be sufficient since most errors would have to do with the id in this instance
|
Aside from my comment about the error output everything looks pretty good @alan-unravel. Just curious, how did you run into this problem and what did the stack trace look like? Just wondering if we should add a regression test to address the issue you hit. |
|
Just a simple run through the parser and requesting the HarPages, surprised the tests didn't catch this. The last pages getattr(self, 'title', None) was always resolving to None and then I was getting a |
|
👍 |
…ed raw pages instead of recursive call to har_parser.pages which reached the recursion limit on failure