Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: adding an IdP and a new Saml RP do not combine in the journey #19

Open
mrochon opened this issue Feb 24, 2022 · 0 comments
Open

Bug: adding an IdP and a new Saml RP do not combine in the journey #19

mrochon opened this issue Feb 24, 2022 · 0 comments

Comments

@mrochon
Copy link
Owner

mrochon commented Feb 24, 2022 •
edited
Loading

Adding SAML RP wdoes not know about all the custom IdPs added below the Base.xml. The resulting SAML_SUSI journey therefore does not include these IdPs. Adding IdPs after adding SAML has a bug which causes it not to add CombinedSignupSignIn steps to an existing journey in an RP xml. Repro:

  1. Add-IefPoliciesIdP - susi/edit updated correctly to use the idP
  2. new-IefPoliciesSamlRP - new SAML_SUSI does not include the new IdPs
    Doing in reverse sequence does not help. Need to implement a more generic xml merge functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrochon