Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capital case? #62

Closed
adius opened this issue Feb 23, 2016 · 4 comments
Closed

Capital case? #62

adius opened this issue Feb 23, 2016 · 4 comments
Assignees
Milestone

Comments

@adius
Copy link

adius commented Feb 23, 2016

Why the hell are the keys in the options object written in capital letters. No need to shout (and shitty to type!)

@mrodrig
Copy link
Owner

mrodrig commented Feb 23, 2016

I guess it was a design choice that I made when starting out with the module. The hard part about changing it now is that the change would have to be backwards compatible (still allow the upper case versions). I'll definitely take a look at fixing it. Thanks!

@mrodrig mrodrig self-assigned this Feb 23, 2016
@adius
Copy link
Author

adius commented Feb 24, 2016

Well you can always increment by a major version number and make backwards incompatible changes…
but having lower and upper simultaneously for the beginning sounds like a good idea.

@mrodrig mrodrig added this to the 2.0.17 milestone Mar 9, 2016
@mrodrig
Copy link
Owner

mrodrig commented Mar 9, 2016

This should be all set in 2.0.17. I updated the documentation to have the lower case option keys. Sorry that it took so long - I had a lot of school work going on. Thanks again for letting me know about this!

@mrodrig mrodrig closed this as completed Mar 9, 2016
@adius
Copy link
Author

adius commented Mar 9, 2016

Looks good! Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants