Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor out activesupport dependency #204

Merged
merged 9 commits into from May 6, 2014
Merged

refactor out activesupport dependency #204

merged 9 commits into from May 6, 2014

Commits on Apr 12, 2014

  1. replace callbacks with procedural method

    callbacks were being used to register where any plugins would execute
    with relation to the main capture method, this replaces callback event
    registration with a simple ordered list in a method.
    
    closer to removing active support dependency, but this is actually
    easier to read and understand IMHO (no more list of callbacks that
    happen in reverse order)
    
    also put some comments in to indicate areas where we don’t have any
    plugins yet, but where they would go (should help with abstraction for
    when we break out third party vs native plugins in future)
    mroth committed Apr 12, 2014
    Copy the full SHA
    a390d02 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2014

  1. determine plugin run order based on plugin itself

    Instead of explicitly defining each plugin that runs in the running,
    each plugin that wants to be run by the runner should define
    self.runner_order with either :precapture or :postcapture.
    
    With this, we can also get rid of some of the ActiveSupport inflection
    metaprogramming stuff that automatically creates method names for
    runner, getting us closer to deprecating the active support gem
    entirely.
    
    NOTE: tests passing but haven’t manually verified with all the
    different plugins yet.
    mroth committed Apr 13, 2014
    Copy the full SHA
    0e6dbac View commit details
    Browse the repository at this point in the history
  2. use Object.const_get instead of constantize

    Removes dependency on active_suppor/inflector
    mroth committed Apr 13, 2014
    Copy the full SHA
    d55ff95 View commit details
    Browse the repository at this point in the history
  3. remove active_support/concern

    This doesnt appear to actually be being used anywhere!
    mroth committed Apr 13, 2014
    Copy the full SHA
    caf61fb View commit details
    Browse the repository at this point in the history
  4. remove active support from gemspec

    all usage of it seems to have been confined to what I just refactored
    out of runner.
    
    TODO: tests are passing but still need to audit the existing plugins,
    as some of them may have taken advantage of the fact we had it loaded,
    and since the plugins general have poor test coverage its possible this
    breaks one.
    mroth committed Apr 13, 2014
    Copy the full SHA
    0c18b80 View commit details
    Browse the repository at this point in the history
  5. move all capturers into a subdirectory

    this has nothing to do with the rest of this PR but it was bothering
    me so I am doing it here anyhow to clean things up.
    mroth committed Apr 13, 2014
    Copy the full SHA
    5c9f079 View commit details
    Browse the repository at this point in the history
  6. chain const_get to handle module namespacing

    const_get only handles automatically splitting on “::” to deal with
    module namespacing on Ruby 2.0+, making the changes introduced in
    d55ff95 fail on earlier versions.
    
    Thus use a chained .const_get to handle getting the module first , then
    the class within the module.
    mroth committed Apr 13, 2014
    Copy the full SHA
    8ac9737 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2014

  1. make separate precapture and postcapture execute phases

    I feel like I’m missing something here and this could be a lot DRYer.
    mroth committed Apr 26, 2014
    Copy the full SHA
    558feda View commit details
    Browse the repository at this point in the history

Commits on May 1, 2014

  1. Copy the full SHA
    cb34890 View commit details
    Browse the repository at this point in the history