fixing windows mini_magick escape issues #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
馃憤 merging |
matthutchinson
added a commit
that referenced
this pull request
Apr 19, 2015
fixing windows mini_magick escape issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To maintain MiniMagick compatibility on Windows for v3.8.1 we need this patch.
It fixes an issue that was introduced in an earlier version of MiniMagick, but was later fixed in 4+
We are locked at v3.8.1 since MiniMagick 4+ dropped support for Ruby 1.8.7. If/when we upgrade MiniMagick to 4.2+ this patch can be removed.
Testing in Windows 8.1 and now working:
馃殌 (also bumps rubocop gem to 0.30 and travis tests on Ruby 2.2.2)