Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion]Tabs_on_Bottom #16

Closed
storm119 opened this issue Nov 3, 2019 · 3 comments
Closed

[Suggestion]Tabs_on_Bottom #16

storm119 opened this issue Nov 3, 2019 · 3 comments

Comments

@storm119
Copy link

storm119 commented Nov 3, 2019

How about change the "toolbar order" in line 44 of Fx65_tabs_on_bottom.css to "0"...this will force "menubar" to stay on top...and we don't need this patch anymore Fx65_tabs_on_bottom_menubar_on_top_patch.css...?

#titlebar{
-moz-box-ordinal-group: 2;
-moz-appearance: none !important;
}

to

#titlebar{
-moz-box-ordinal-group: 0;
-moz-appearance: none !important;
}

Or probably adding complete order rules....

print-preview-toolbar,
#printedit-toolbar,
#titlebar {
  -moz-box-ordinal-group: 0;
}
#navigator-toolbox #toolbar-menubar {
  -moz-box-ordinal-group: 1;
}
/* navigation toolbar */
#navigator-toolbox #nav-bar {
  -moz-box-ordinal-group: 2;
}
/* bookmarks toolbar */
#navigator-toolbox #PersonalToolbar {
  -moz-box-ordinal-group: 3;
}
/* 3rd party toolbars */
#navigator-toolbox toolbar {
  -moz-box-ordinal-group: 10;
}
/* tabs toolbar */
#navigator-toolbox #TabsToolbar {
  -moz-box-ordinal-group: 100;
}

Ps: tested on my Linux (Manjaro 18.1.2 Arch Gnome Testing branch) with FF70 + FF71 Developer Edition and worked just fine...at least on my side

Ps2: the complete order rules codes above inspired by Aris2-t2 (CTR) works

@storm119
Copy link
Author

storm119 commented Nov 3, 2019

Edit: Sorry...spoke to soon need another codes to make em works right...I had alot customization codes which actually make above codes working on my side...my bad!

@storm119 storm119 closed this as completed Nov 3, 2019
@storm119
Copy link
Author

storm119 commented Nov 3, 2019

Update: after a little investigation...this code need to add to make above codes working correctly...

 #TabsToolbar {
  position: absolute !important;
  display: block !important;
  bottom: -2px !important;
  width: 100vw !important;
  border-bottom: none !important;
}
#tabbrowser-tabs {
  width: 100vw !important;
  margin-bottom: -1px !important;
  /* tabs gib me some space at left|right screen */
  -moz-margin-start: 4px !important;
  -moz-margin-end: 4px !important;
}

:root {
  --tab-min-height: 32px !important;
}
:root[uidensity="compact"] {
  --tab-min-height: 28px !important;
}
:root[uidensity="touch"] {
  --tab-min-height: 40px !important;
}

/* tab height */
#tabbrowser-tabs,
#TabsToolbar :-moz-any(.tabs-newtab-button,#tabs-newtab-button),
#tabbrowser-tabs > .tabbrowser-arrowscrollbox,
#tabbrowser-tabs[positionpinnedtabs] > .tabbrowser-arrowscrollbox > .tabbrowser-tab[pinned] {
  min-height: var(--tab-min-height) !important;
}
#main-window:not([chromehidden*="toolbar"]) #navigator-toolbox {
  padding-bottom: calc(0px + var(--tab-min-height)) !important;
}
.tabbrowser-tab {
  min-height: var(--tab-min-height) !important;
  border: none !important;
  -moz-box-sizing: border-box !important;
}

@storm119 storm119 reopened this Nov 3, 2019
@MrOtherGuy
Copy link
Owner

Since you are doing basically #TabsToolbar { display: block !important; } the -moz-box-oridinal-group on it will do absolutely nothing. If you are using the code in your last post then the whole code where you listed bunch of -moz-box-ordinal groups is totally irrelevant.

I would rather keep #TabsToolbar displayed as -moz-box (like it is currently) for easier compatibility with other modifications. Then, if someone really wants to have menubar shown on top it can be relatively easily hacked there with the menubar on top patch. And that should not have too many compatibility problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants