Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autohide_toolbox.css - window moved down 8px #45

Closed
megaslowpoke opened this issue May 11, 2020 · 7 comments
Closed

autohide_toolbox.css - window moved down 8px #45

megaslowpoke opened this issue May 11, 2020 · 7 comments

Comments

@megaslowpoke
Copy link

The whole window moved down 8px(?), and therefore, for example: the hint link (when you hover over a link) is not visible full in the lower left corner.

@MrOtherGuy
Copy link
Owner

What OS do you use that with?

@megaslowpoke
Copy link
Author

Windows 10, Firefox 76.0.1 x64, also tried to turn off all add-ons.

@MrOtherGuy
Copy link
Owner

Wow, how have I not catched that. Well, it should be fixed now.

@megaslowpoke
Copy link
Author

Thank you so much, now everything is fine.

@megaslowpoke
Copy link
Author

Empirically, I found out that for Windows 7 and Firefox 76.0.1 it works normally with the following parameters:

...(-moz-os-version: windows-win7){
:root[tabsintitlebar][sizemode="maximized"]:not([inDOMFullscreen]) > body > box{margin-top: 6px !important; }...

It might be worth adding if you want to support Windows 7.

@MrOtherGuy
Copy link
Owner

Well I don't generally pay too much attention to Win7 because 1. it's deprecated and 2. it probably doesn't have too many users and 3. I don't have any Win7 system to test things with.

I could add rules for it though, but the important bit is what is seen in the stylesheet that Windows10 at least requires different values depending on the OS scaling. It's bloody annoying and -moz-appearance normally handles that, but since the style needs to set -moz-appearance to none well need to add those margins manually.

So your margin-top: 6px may work on the OS scaling of whatever you have applied (such as 125%) but it probably does not work on 150% or 100%. Or it might, I genuinely don't know.

I wouldn't normally go as far as to set values for every scaling factor, but since this particular style requires pixel-perfect layout for it to do the one thing it's supposed to do I feel it's worth it.

@megaslowpoke
Copy link
Author

In any case, now if anyone searches for support for Windows 7, they will be able to read here what needs to be changed. I think this is quite enough.

Thank you for this kit and its support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants