Skip to content
This repository has been archived by the owner on Jul 18, 2020. It is now read-only.

Imgur uploading account is not correctly #11

Closed
dungvt opened this issue Oct 16, 2017 · 1 comment
Closed

Imgur uploading account is not correctly #11

dungvt opened this issue Oct 16, 2017 · 1 comment

Comments

@dungvt
Copy link

dungvt commented Oct 16, 2017

Hi all,
I found some issues about uploading account of project and refresh token:

  1. If we alway create new "ImgurClient" object with "ClientId" and "ClientSecret", we alway upload that image to application's account (see image: https://i.imgur.com/GuZ0wl4.png)
  2. We alway call to "Login()" function on ImgurUploader class when rase upload action. This is not good solution for perfomence. I think we need check the "ExpiresIn" or "ExpiresAt" before refresh token.

Thanks!

@mrousavy
Copy link
Owner

Thanks for the issue! Take a look at my last 3-4 commits, I've "cached" the instance now. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants