feat: added expo plugin #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is huge, nice work man & thanks for the PR! all looks good, LGTM 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a config plugin for Expo which makes both of the necessary changes for the CoreML delegate on iOS:
$EnableCoreMLDelegate=trueto the top of the PodfileI took the liberty of adopting the plugin prop
enableCoreMLDelegateand its documentation from your draft PR (#18). If the user doesn't set this totrue, the plugin effectively does nothing. Everything else, as in the changes to the Metro file, need to be done by the user himself and can't / shouldn't be done through the config plugin. Therefore, this plugin is only there for enabling the CoreML delegate.Tested with a fresh project on Expo SDK 50.
Closes #6.