fix getBoolean on the Web #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web saves values in string format. so 'false' is always true
|
Hey, thanks for the PR this is a good change, I missed that one! |
mrousavy
reviewed
Apr 19, 2022
src/createMMKV.web.ts
Outdated
Comment on lines
45
to
52
| /** | ||
| * local storage saves keys and values in utf-16 dom strings | ||
| * @link https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage#description | ||
| * true is saved as 'true', false as 'false' | ||
| * so if value == 'true' return true | ||
| * if value == 'false' return false | ||
| * I just simplified the conditions | ||
| */ |
There was a problem hiding this comment.
Can you just remove this comment?
remove comments
|
Great! Thanks for your PR 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local storage saves values in string format. so Boolean('false') is always true. for this method to work correctly, it should check if value is 'true' or 'false' as string and returns the condition result.
to simplify the code I just return value === 'true'