iOS/app-group MMKV MultiProcess mode #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reordering cheks to check nil first for readability
|
Awesome! Thanks for your PR, this looks pretty good - I think I'm gonna follow up with an expo config plugin and then we can release it. Can you confirm that it works both with AppGroup enabled and with a Path passed? |
|
Perfect! Thank you 🙇 Just revalidated: if both |
|
Hey @mrousavy, just to be on the same page, do I need to do anything else on my side or i can relax and wait? 😁 |
|
Hey sorry man my bad, let's merge this thanks so much for your contribution! |
|
This looks great! @mrousavy are you still planning to implement a Config Plugin? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicating existing PR #402 and following on open comments as would like to use this change in my code.