Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Video output #1023

Closed
3 of 4 tasks
powerpivar opened this issue Apr 27, 2022 · 3 comments · Fixed by #1466
Closed
3 of 4 tasks

🐛 Video output #1023

powerpivar opened this issue Apr 27, 2022 · 3 comments · Fixed by #1466
Labels
🐛 bug Something isn't working

Comments

@powerpivar
Copy link

What were you trying to do?

I wanted to record a video on Android with video format 640x480 but the video output did not corespondent to camera view input, with video format 1280x720 works fine.

For IOS works fine in both resolutions.

Reproduceable Code

const format = useMemo(() => {
    if (device) {
      return device.formats.find((item) => item.videoWidth === 640 && item.videoHeight === 480);
    }
    return null;
  }, [device]);

What happened instead?

Instead of getting the same video output as input, the recorded video is smaller than the camera view input.

Relevant log output

No response

Device

Xiaomi Mi 8 Lite

VisionCamera Version

2.13.2

Additional information

@powerpivar powerpivar added the 🐛 bug Something isn't working label Apr 27, 2022
@powerpivar
Copy link
Author

Hi @mrousavy, any update here?

@pradeep61993
Copy link

I am also looking for the this solution.
Any updated ?

@mrousavy
Copy link
Owner

Hey! I've rewritten the entire Android codebase of VisionCamera from CameraX to Camera2 in the efforts of ✨ VisionCamera V3.

I just now completed the Camera2 rewrite and I believe the core structure is running, but there might be some edge cases to iron out. Can you try and test the PR #1674 for me to see if you can still reproduce this issue here?

Here's an instruction on how you can test that: #1674 (comment)

If the issue cannot be reproduced with that version/PR anymore, then hoorayy, I fixed it! 🎉
Otherwise please let me know and I'll keep this issue open to keep track of it.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants