chore: add session prefix to audio-session-failed-to-activate error #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yes! Weird that the CI fails because of REA in node_modules, but everything looks good to me, LGTM! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I'm not sure about whether I am missing anything here or if I'm simply confused. I got an error yesterday, that was:
When I was browsing the code to look for other possible errors, I saw that while all other errors had a domain/group prefix, the
audio-session-failed-to-activatewas the only one that had not. Looks like the error itself is being logged by the native code though.Changes
This PR fixes the missing error domain for the
audio-session-failed-to-activateerror.Tested on
iPhone 13 Pro