-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
❓ shutter sound not playing on Android #1044
Comments
I don't think there is any default shutter sound effect on Android? |
@mrousavy A disclaimer in the documentation might be a good idea. Since people testing on both types of devices will probably get thrown off by it? Or, I was considering making a PR that would add this feature since there is technically a default sound for this in the Android OS if you'd be open to that. |
from their docs:
Why doesn't it play then? I think this would be a cool option for VisionCamera. It's configurable both on iOS and Android |
True, I would assume it'd play anyways. A bit more annecdotal evidence, but in my recent implementation of VisionCamera on Android it also was not playing on my phone when taking a picture. Looking back at the old code for RN Camera, it seems they manually called the sound directly instead of using it from https://github.com/react-native-camera/react-native-camera/pull/1441/files |
any update? i need to reproduce shutter sound |
+1, we just switched from RNC to RCVC, the missing shutter sound makes our client unhappy. 😭 |
+1, please add shutter sound |
Stop spamming +1. If you want me to work on VisionCamera to make your client happy, pay me to do so. |
@mrousavy Based on the code from RN Camera shared by @kesteer and the fact that android docs also point to Keep up the good work, this library is awesome! |
On android some devices, flash and shutter is not working. |
Hey! I just implemented this in V3! :) #1702 |
Question
The camera shutter sound plays in ios, but the shutter sound does not play in Android.
What I tried
react-native: 0.68.0
VisionCamera Version
2.13.3
Additional information
The text was updated successfully, but these errors were encountered: