Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Mute phone call sound on Android #1330

Closed
3 of 4 tasks
NataliaNobre opened this issue Nov 8, 2022 · 2 comments · Fixed by #1466
Closed
3 of 4 tasks

🐛 Mute phone call sound on Android #1330

NataliaNobre opened this issue Nov 8, 2022 · 2 comments · Fixed by #1466
Labels
🐛 bug Something isn't working

Comments

@NataliaNobre
Copy link

What were you trying to do?

When I'm recording a video on Android and I receive a phone call the sound of the phone ringing is on the recording.

This was fixed for iOS on this release but the issue continues on Android.

Reproduceable Code

No response

What happened instead?

Instead of continuing the recording with no sound of the phone ringing you can hear the phone notification on the video.

Relevant log output

No response

Device

Samsung S20

VisionCamera Version

2.15.0

Additional information

@NataliaNobre NataliaNobre added the 🐛 bug Something isn't working label Nov 8, 2022
@franbe7
Copy link

franbe7 commented Nov 17, 2022

I'm having the same issue

@mrousavy
Copy link
Owner

Hey! I've rewritten the entire Android codebase of VisionCamera from CameraX to Camera2 in the efforts of ✨ VisionCamera V3.

I just now completed the Camera2 rewrite and I believe the core structure is running, but there might be some edge cases to iron out. Can you try and test the PR #1674 for me to see if you can still reproduce this issue here?

Here's an instruction on how you can test that: #1674 (comment)

If the issue cannot be reproduced with that version/PR anymore, then hoorayy, I fixed it! 🎉
Otherwise please let me know and I'll keep this issue open to keep track of it.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants