Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Error in build type resolution #1379

Closed
3 of 4 tasks
Dallas62 opened this issue Dec 10, 2022 · 1 comment · Fixed by #1466
Closed
3 of 4 tasks

🐛 Error in build type resolution #1379

Dallas62 opened this issue Dec 10, 2022 · 1 comment · Fixed by #1466
Labels
🐛 bug Something isn't working

Comments

@Dallas62
Copy link

Dallas62 commented Dec 10, 2022

What were you trying to do?

I wanted to build release build.

Reproduceable Code

Just a clean build with the library.

What happened instead?

Crash in the resolution of library link, looking for a debug library in release build.

Probably related to

Relevant log output

Didn't reproduce error after full clean, but build type resolution still select debug on release build.

def resolveBuildType() {
    def buildType = "debug"
    tasks.all({ task ->
        logger.warn("VisionCamera:  ========================>>>>>>> TASK NAME ${task.name}")
        if (task.name == "buildCMakeRelease") {
            buildType = "release"
        }
    })
    return buildType
}

Return debug in any case.

The right task.name might be: buildCMakeRelWithDebInfo

Device

Android build

VisionCamera Version

2.9.3

Additional information

@Dallas62 Dallas62 added the 🐛 bug Something isn't working label Dec 10, 2022
@Dallas62 Dallas62 changed the title 🐛 Error in build ty resolution 🐛 Error in build type resolution Dec 10, 2022
@myselfuser1
Copy link

@mrousavy
Copy link
Owner

Hey! I've rewritten the entire Android codebase of VisionCamera from CameraX to Camera2 in the efforts of ✨ VisionCamera V3.

I just now completed the Camera2 rewrite and I believe the core structure is running, but there might be some edge cases to iron out. Can you try and test the PR #1674 for me to see if you can still reproduce this issue here?

Here's an instruction on how you can test that: #1674 (comment)

If the issue cannot be reproduced with that version/PR anymore, then hoorayy, I fixed it! 🎉
Otherwise please let me know and I'll keep this issue open to keep track of it.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants