🐛 camera crashes when implementing tap to focus

[rynell-lee]

What were you trying to do?

I am trying to implement tap to focus feature using the focus feature and react-native-gesture-handler tap gesture function.

Reproduceable Code

const singleTap = Gesture.Tap()
    .maxDuration(250)
    .onStart(async (event: TapGestureHandlerEventPayload) => {
      // console.log(event);
      let point: Point = {
        x: event.x,
        y: event.y,
      };
      console.log(point);
      try {
        cameraRef.current?.focus(point);
      } catch (err) {
        console.error(err);
      }
    });

<GestureDetector gesture={Gesture.Exclusive(singleTap)}>
        <Camera
          ref={cameraRef}
          style={StyleSheet.absoluteFill}
          device={device}
          isActive={isAppForeground}
          preset="high"
          video={true}
          audio={true}
          enableZoomGesture={true}
          onInitialized={() => SetReady(true)}
          onError={(error) => {
            console.log(error);
          }}
        />
      </GestureDetector>

What happened instead?

I am able to log out the x and y coordinates showing that the tap function works, however when I implemented the focus function my camera immediately crashes. I tried catching the error but it was not logged out.

Relevant log output

No response

Device

Samsung Galaxy tab S8 (Android 12)

VisionCamera Version

2.15.2

Additional information

• I am using Expo
• I have read the Troubleshooting Guide
• I agree to follow this project's Code of Conduct
• I searched for similar issues in this repository and found none.

[demsr]

@rynell-lee please make sure your device supports focus

[rynell-lee]

@rynell-lee please make sure your device supports focus

@demsr my device supports focus!

[guiac]

same here. any solution?

[demsr]

@guiac @rynell-lee Can you one of you provide a minimal (not) working example and push it to github? I can only check on ios though

[myselfuser1]

Try this https://www.youtube.com/playlist?list=PLQhQEGkwKZUrempLnmxjt7ZCZJu1W3p2i

[mrousavy]

Hey! I've rewritten the entire Android codebase of VisionCamera from CameraX to Camera2 in the efforts of ✨ VisionCamera V3.

I just now completed the Camera2 rewrite and I believe the core structure is running, but there might be some edge cases to iron out. Can you try and test the PR #1674 for me to see if you can still reproduce this issue here?

Here's an instruction on how you can test that: #1674 (comment)

If the issue cannot be reproduced with that version/PR anymore, then hoorayy, I fixed it! 🎉
Otherwise please let me know and I'll keep this issue open to keep track of it.

Thank you!

[mrousavy]

Ohh actually I think in that PR I forgot to add touchToFocus, so I still need to implement that!