Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Android build error in monorepo #1398

Closed
3 of 4 tasks
Sid-Turner-Ellis opened this issue Dec 22, 2022 · 3 comments · Fixed by #1466
Closed
3 of 4 tasks

🐛 Android build error in monorepo #1398

Sid-Turner-Ellis opened this issue Dec 22, 2022 · 3 comments · Fixed by #1466
Labels
🐛 bug Something isn't working

Comments

@Sid-Turner-Ellis
Copy link

What were you trying to do?

Install and build React native app with react-native-vision-camera within a monorepo

Reproduceable Code

No response

What happened instead?

Getting a gradle build error that disappears after I remove the react-native-vision package and reoccurs after I re-install it

Relevant log output

The Android Gradle plugin supports only kotlin-android-extensions Gradle plugin version 1.6.20 and higher.
The following dependencies do not satisfy the required version:
project ':react-native-safe-area-context' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.6.10

Device

Android

VisionCamera Version

2.15.2

Additional information

@Sid-Turner-Ellis Sid-Turner-Ellis added the 🐛 bug Something isn't working label Dec 22, 2022
@Sid-Turner-Ellis
Copy link
Author

Sid-Turner-Ellis commented Dec 23, 2022

Fixed this by using patch package to set the kotlin version to 1.6.20 instead of 1.5.x in grade.properties, closing it because I don't think its related to monorepos rather than the packages I had in my monorepo

@Sid-Turner-Ellis
Copy link
Author

Sid-Turner-Ellis commented Dec 24, 2022

Re-opening this as though its stopping the build error my app is crashing whenever the camera opens, has anyone had success getting this in a monorepo?

@myselfuser1
Copy link

@mrousavy
Copy link
Owner

Hey! I've rewritten the entire Android codebase of VisionCamera from CameraX to Camera2 in the efforts of ✨ VisionCamera V3.

I just now completed the Camera2 rewrite and I believe the core structure is running, but there might be some edge cases to iron out. Can you try and test the PR #1674 for me to see if you can still reproduce this issue here?

Here's an instruction on how you can test that: #1674 (comment)

If the issue cannot be reproduced with that version/PR anymore, then hoorayy, I fixed it! 🎉
Otherwise please let me know and I'll keep this issue open to keep track of it.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants