Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Flash light turn off when its used with frameprocessor🐛 #1687

Closed
3 of 4 tasks
ravirajcm opened this issue Aug 10, 2023 · 2 comments · Fixed by #1466
Closed
3 of 4 tasks

[Android] Flash light turn off when its used with frameprocessor🐛 #1687

ravirajcm opened this issue Aug 10, 2023 · 2 comments · Fixed by #1466
Labels
🐛 bug Something isn't working

Comments

@ravirajcm
Copy link

What were you trying to do?

I am trying to use with frameprocessor also setting torch as 'on' with "useScanBarcodes" as QR to read QR codes.
But as soon as it detect QR it turn of the flash light even I have torch set as 'on'.

Reproduceable Code

<Camera
        ref={CameraRef}
        torch={flash}
        device={device}
        frameProcessor={frameProcessor}
        frameProcessorFps={5}
        isActive={!shouldPauseCamera}
      />

What happened instead?

It should keep torch on when torch='on' and off when torch='off'

Relevant log output

No response

Device

Samsung S22 plus

VisionCamera Version

2.15.4

Additional information

@ravirajcm ravirajcm added the 🐛 bug Something isn't working label Aug 10, 2023
@mrousavy
Copy link
Owner

Hey! I've rewritten the entire Android codebase of VisionCamera from CameraX to Camera2 in the efforts of ✨ VisionCamera V3.

I just now completed the Camera2 rewrite and I believe the core structure is running, but there might be some edge cases to iron out. Can you try and test the PR #1674 for me to see if you can still reproduce this issue here?

Here's an instruction on how you can test that: #1674 (comment)

If the issue cannot be reproduced with that version/PR anymore, then hoorayy, I fixed it! 🎉
Otherwise please let me know and I'll keep this issue open to keep track of it.

Thank you!

@mrousavy
Copy link
Owner

Hey - I'm tracking Flash in this feature request/issue now: #1890

Make sure to upvote or sponsor to support this feature, and leave a comment if you have any additional thoughts/ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants