fix: Trigger measure and layout manually to fix Preview stretching
#2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
While the aspect ratio calculations for the Preview View are now seemingly correct (I think), there were some issues reported by users that the Preview View was still stretched.
According to this comment: #2583 (comment) the
onMeasurefunction was not called after updating the Surface size. I believe this is related to this bug in react-native: facebook/react-native#17968 - which meansrequestLayoutdoes not callonMeasure.So in this PR I fix this by manually calling
measurefor this component, so it callsonMeasureas expected - causing the PreviewView to update it's aspect ratio accordingly.Changes
Tested on
Related issues