Boolean.parse string values from gradle properties

[jthure]

What

The properties VisionCamera_disableFrameProcessors and VisionCamera_enableCodeScanner when defined is returned as strings by rootProject.ext.get. So when for example setting VisionCamera_enableCodeScanner=false in gradle.properties, the read value of it is the string"false". It is later used in a conditional, but if("false") evaluates to true which is not the intended behaviour.

Changes

Use Boolean.parse to parse props that are expected to have a boolean value

Tested on

Related issues

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-vision-camera	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 25, 2024 11:27am

[mrousavy]

Hey - thanks for your PR, but the line is a bit messy - could you instead create a separate function below safeExtGet called safeExtGetBool that does this parsing?

Thank you!

[jthure]

Hey - thanks for your PR, but the line is a bit messy - could you instead create a separate function below safeExtGet called safeExtGetBool that does this parsing?

Thank you!

Done!

[mrousavy]

Awesome, thanks man LGTM!