fix: Use 0x0 as a fallback Size if SENSOR_INFO_PHYSICAL_SIZE is null (e.g. on USB cameras)

[BrainLei]

…cs cannot get the SENSOR_INFO_PHYSICAL_SIZE value of the camera device

What

Changes

Tested on

Related issues

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-vision-camera	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 27, 2024 2:50am

[mrousavy]

Hey - thanks for the PR this is a good fix. I'm hoping a size of 0x0 won't cause any issues later, e.g. divisions by zero in zooming or similar. But we'll see.

Did you run yarn check-all in the package/ directory? Looks like it is not formatted properly, please do that.

[mrousavy]

Actually it is formatted properly - nevermind!

[BrainLei]

Hey - thanks for the PR this is a good fix. I'm hoping a size of 0x0 won't cause any issues later, e.g. divisions by zero in zooming or similar. But we'll see.

Did you run yarn check-all in the package/ directory? Looks like it is not formatted properly, please do that.

Hi, Mrousavy
I think it should not affect the zoom operation because:
1 sensorSize seems to be only used in the calling path of getDeviceTypes->getMaxFieldOfView->getFieldOfView, and not used elsewhere.
2 Generally, when the SENSOR_INFO_PHYSICAL_SIZE value cannot be obtained, the camera will not be used as a preview scene.

[BrainLei]

Actually it is formatted properly - nevermind!

I tested yarn check-all on the main branch, and these Formatting errors also exist.
The error is as follows:
Formatting Swift code.. error: SwiftFormat not installed, install with 'brew install swiftformat' (or manually from https://github.com/nicklockwood/SwiftFormat) Linting Swift code.. error: SwiftLint not installed, install with 'brew install swiftlint' (or manually from https://github.com/realm/SwiftLint) Linting Kotlin code.. error: KTLint not installed, install with 'brew install ktlint' (or manually from https://github.com/pinterest/ktlint) Formatting C++ code.. error: clang-format not installed, install with 'brew install clang-format' (or manually from https://clang.llvm.org/docs/ClangFormat.html) Linting JS/TS code..

[mrousavy]

lgtm!

[mrousavy]

the error is btw that you didnt install the tools. you need them to format.

[BrainLei]

tools

I get it, I will install the tools immediately, thank you