Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix RCTBlockGuard not found error #2781

Merged
merged 5 commits into from Apr 22, 2024
Merged

Conversation

mrousavy
Copy link
Owner

@mrousavy mrousavy commented Apr 22, 2024

What

Simplifies the JSINSObjectConversion class to avoid depending on ReactCommon.

Changes

Tested on

Related issues

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 8:01pm

@mrousavy mrousavy merged commit 0e5a888 into main Apr 22, 2024
11 checks passed
@mrousavy mrousavy deleted the fix/fix-blockguard-not-found branch April 22, 2024 20:12
fahadhaque007 pushed a commit to equinoxventures/react-native-vision-science-camera that referenced this pull request May 3, 2024
* fix: Fix `RCTBlockGuard` not found error

* Simplify

* fix: Simplify `JSINSObjectConversion`

* fix: Fix wrong uses of the JSI Converter

* fix: Use strong-typed `jsi::Object` -> `NSDictionary*` converter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant