fix: Correct android filenames for takeSnapshot [v4] #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
utk994-swig
changed the title
utk994-swig
changed the title
utk994-swig
changed the title
|
Thank you very much, nice catch man! ❤️ LGTM |
fahadhaque007
pushed a commit
to equinoxventures/react-native-vision-science-camera
that referenced
this pull request
May 3, 2024
fix: add dot to snapshot filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes the filename generated when calling
takeSnapshoton AndroidCurrently they are generated without a
.in the filename. Eg:mrousavy-1692260572662396982jpgChanges
Tested on
Related issues