Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ How do I enable/disable the shutter sound #311

Closed
3 of 4 tasks
jzxchiang1 opened this issue Jul 31, 2021 · 15 comments · Fixed by #1466
Closed
3 of 4 tasks

✨ How do I enable/disable the shutter sound #311

jzxchiang1 opened this issue Jul 31, 2021 · 15 comments · Fixed by #1466
Labels
✨ feature Proposes a new feature or enhancement

Comments

@jzxchiang1
Copy link

Question

How do I enable or disable the shutter sound when taking a photo?

For some reason, when testing on my physical iPhone device, the sound plays when flash is off but doesn't play when flash is on.

Is this customizable? Thanks!

What I tried

No response

VisionCamera Version

2.4.1

Additional information

@jzxchiang1 jzxchiang1 added the 💭 question Further information is requested label Jul 31, 2021
@mrousavy
Copy link
Owner

The shutter sound is always played in the image capture pipeline:

But it looks like this actually can be customized by disposing the sound (see this SO post). I'll mark this as a feature request and get to this soon

@mrousavy mrousavy added ✨ feature Proposes a new feature or enhancement and removed 💭 question Further information is requested labels Jul 31, 2021
@mrousavy mrousavy changed the title How do I enable/disable the shutter sound❓ ✨ How do I enable/disable the shutter sound Jul 31, 2021
@mrousavy
Copy link
Owner

mrousavy commented Jan 4, 2022

yeah it's pretty easily possible - will take a look soon. Does the shutter sound also play on Android?

@PABourdais
Copy link

On android native camera there is a shutter sound

@siddharth-kt
Copy link

any update on this guys ?

@JurianBoots
Copy link

Hey @mrousavy, any update? This feature would be awesome! :)

@mrousavy
Copy link
Owner

mrousavy commented Feb 4, 2022

Hey @JurianBoots, unfortunately not yet. I've had higher priorities in the past few days, such as my agency Margelo, as well as other issues/PRs in VisionCamera/MMKV created by my GitHub sponsors.

@wassgha
Copy link

wassgha commented May 25, 2022

Could we please prioritize either this, or taking snapshots on iOS? I'm trying to make blurry previews of the camera, ideally this would be a low-quality snapshot but since that's not available on iOS I resorted to taking photos which plays the shutter sound even though the user did not trigger the photo.

@mrousavy
Copy link
Owner

Could we please prioritize either this

Sure, you can prioritize this. Shoot me a PR if you have a working change.

@wassgha
Copy link

wassgha commented May 31, 2022

Yea just a sec

@wilav-dev
Copy link

Hello, any update?

@RONAKDHOLARIYA
Copy link

RONAKDHOLARIYA commented Oct 4, 2022

I found a way to disable the shutter should

  1. open PhotoCaptureDelegate
  2. find func photoOutput
  3. add given line into the function and rebuild the app
// dispose system shutter sound 
AudioServicesDisposeSystemSoundID(1108) 

@mrousavy
Copy link
Owner

Hey! I just implemented this in V3! :) #1702

@jagdeepChicmic
Copy link

file shoes merged but code not reflected in 2.16.1 version(for ios)

@jeemercado
Copy link

@mrousavy any way we could update this for V2?

@mrousavy
Copy link
Owner

mrousavy commented Dec 5, 2023

Hey - no, this is a V3 feature. I'm not adding any more features to V2, as I already spend a lot of time on V3 and I don't have any more free time to dedicate to V2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature Proposes a new feature or enhancement
Projects
None yet
10 participants