Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Screen transitions broken in Example App🐛 #542

Closed
3 of 4 tasks
ldstein opened this issue Oct 19, 2021 · 2 comments · Fixed by #1466
Closed
3 of 4 tasks

Android: Screen transitions broken in Example App🐛 #542

ldstein opened this issue Oct 19, 2021 · 2 comments · Fixed by #1466
Labels
🐛 bug Something isn't working

Comments

@ldstein
Copy link

ldstein commented Oct 19, 2021

What were you trying to do?

On Android, if the Permissions Screen is displayed and permission is granted to Camera and Microphone, the view will fail to transition to the Camera Screen.

Current workaround is after granting permission, terminate the app and reload - it will then directly load the Camera screen.

I believe it is caused by an incompatibility between @react-navigation/native and react-native-reanimated@2.3.0-beta.2 and is not unique to the Example App (navigation is broken in other projects where I've introduced the alpha or beta versions of RNR).

The example App screen transitions haven't worked on Android since ~2.7.0 after the move away from wix/react-native-navigation.

Maybe worth watching software-mansion/react-native-reanimated#2460 as it looks related.

image

Reproduceable Code

https://github.com/mrousavy/react-native-vision-camera/tree/7206a794a9e1a2da4def7fdf4d8a70c9eb7f43ff/example

What happened instead?

Permission Screen displayed instead of Camera Screen

Relevant log output

N/A

Device

Pixel 3, Pixel 3XL, Android 11

VisionCamera Version

2.9.3

Additional information

@ldstein ldstein added the 🐛 bug Something isn't working label Oct 19, 2021
@ldstein ldstein changed the title Screen transitions broken in Example App on Android🐛 Android: Screen transitions broken in Example App🐛 Oct 19, 2021
@mrousavy
Copy link
Owner

Thanks for the bug report!

@mrousavy
Copy link
Owner

Hey! I've rewritten the entire Android codebase of VisionCamera from CameraX to Camera2 in the efforts of ✨ VisionCamera V3.

I just now completed the Camera2 rewrite and I believe the core structure is running, but there might be some edge cases to iron out. Can you try and test the PR #1674 for me to see if you can still reproduce this issue here?

Here's an instruction on how you can test that: #1674 (comment)

If the issue cannot be reproduced with that version/PR anymore, then hoorayy, I fixed it! 🎉
Otherwise please let me know and I'll keep this issue open to keep track of it.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants