-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Android: Return Video size and duration #77
Comments
@mrousavy would love to have feature parity here. Missing the duration for android. |
This is actually implemented on Android already with one of my latest PRs. |
Oh really? Duration is there for android? I just implemented ffprobe and some crazy async tasks for it :D |
Did you check if it was there? |
Nope, I saw this ticket and I knew it wasn't there couple of weeks ago. |
Yes, it is there... |
On Android the video duration and size are not set correctly because CameraX doesn't provide that information in the Callback.
https://github.com/cuvent/react-native-vision-camera/blob/dff8fc71788311c324e6eb80976a6ec50596d3e5/android/src/main/java/com/mrousavy/camera/CameraView%2BRecordVideo.kt#L32-L36
The only workaround for this would be reading the Video's Metadata, but that's an extra overhead I don't want to introduce.
With frame processors I'm going to have to create a custom Video recorder and encoder anyways, I can manually use a stopwatch for this then. So #2 probably fixes this issue.
The text was updated successfully, but these errors were encountered: