Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 google pixel 4a, has night sight, though lib returns supportsLowLightBoost: false #945

Closed
3 of 4 tasks
nikoloz110 opened this issue Mar 28, 2022 · 2 comments · Fixed by #1466
Closed
3 of 4 tasks
Labels
🐛 bug Something isn't working

Comments

@nikoloz110
Copy link

What were you trying to do?

I want to achieve the same effect with vision camera, as when I turn on night sight on my native google pixel 4a camera. but the vision camera api tells me that the wide-camera (back), supportsLowLightBoost: false. is this some kind of bug, or just a different thing?

Reproduceable Code

No response

What happened instead?

supportsLowLightBoost: false, I think it should return true, since my camera has, night sights

Relevant log output

No response

Device

google pixel 4a

VisionCamera Version

2.13.0

Additional information

@nikoloz110 nikoloz110 added the 🐛 bug Something isn't working label Mar 28, 2022
@mrousavy
Copy link
Owner

Hey! I've rewritten the entire Android codebase of VisionCamera from CameraX to Camera2 in the efforts of ✨ VisionCamera V3.

I just now completed the Camera2 rewrite and I believe the core structure is running, but there might be some edge cases to iron out. Can you try and test the PR #1674 for me to see if you can still reproduce this issue here?

Here's an instruction on how you can test that: #1674 (comment)

If the issue cannot be reproduced with that version/PR anymore, then hoorayy, I fixed it! 🎉
Otherwise please let me know and I'll keep this issue open to keep track of it.

Thank you!

@mrousavy
Copy link
Owner

Maybe the low light boost feature is an extension exposed through Camera2 only, CameraX only, or not exposed at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants