Fix takeSnapshot not working on Android #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing previewView.bitmap was throwing an error because it wasn't being done on the main thread. Any access to previewView needs to be done on the main (UI) thread. This commit fixes the issue by ensuring this access is now run on the main thread. Fixes mrousavy#547
|
Hey - thanks again for the PR man! LGTM 🚀 |
This was referenced May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Calling
takeSnapshoton Android throws an error that it needs to run on the main thread (#547).Changes
This is similar to something I saw in the PR I made yesterday (#958). The fix is just to wrap the access of
previewView.bitmapin awithContextto ensure it runs on the main thread.Tested on
Android 9 emulator
Android 10 device
Related issues
Fixes #547