Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previously cancelled worker pipeline executions fails when the framework is restarted #37

Closed
NJLangley opened this issue Jul 21, 2020 · 1 comment · Fixed by #39
Closed
Assignees
Labels
bug Something isn't working

Comments

@NJLangley
Copy link
Contributor

Describe the bug
If you cancel a running worker pipeline, the framework stops in the same way as if an error happened (in simple failure handling mode) . If you then restart the framework processing, instead of re-running the worker pipeline, it fails to reset the state and the parent framework pipeline fails without triggering any child pipelines.

Affected services
Which resource within the processing framework does this affect?

  • All of them

To Reproduce
Steps to reproduce the behavior:

  1. Trigger a new run in Data Factory
  2. Cancel one of the worker pipelines
  3. Wait for the current framework execution to complete
  4. Check the current executions table - the cancelled pipeline should have a status of Cancelled/Unknown
  5. Re-run the framework parent pipeline. The framework fails to restart the processing cleanly like it does for a failed execution.

Expected behaviour
A cancelled pipeline should be restart-able like a failed pipeline.

Additional context
I have a branch on my fork with a fix, will submit a PR with the details

@NJLangley NJLangley added the bug Something isn't working label Jul 21, 2020
@mrpaulandrew
Copy link
Owner

Replicated. Investigating fix.

@mrpaulandrew mrpaulandrew linked a pull request Jul 22, 2020 that will close this issue
Framework Internal Backlog automation moved this from In progress to Released Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants