Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email alerts sent to blank email addresses when using specific alert bit flags #38

Closed
NJLangley opened this issue Jul 21, 2020 · 0 comments · Fixed by #39
Closed

Email alerts sent to blank email addresses when using specific alert bit flags #38

NJLangley opened this issue Jul 21, 2020 · 0 comments · Fixed by #39
Assignees
Labels
bug Something isn't working

Comments

@NJLangley
Copy link
Contributor

Describe the bug
When alerting is setup using the bit mask to specify specific alerts only, eg Errors, the proc to determine if alerts should be processed returned before the outcome was known. This meant a successful worker configured to only alert on failure would make the framework child pipeline fail when processing the alerts as it would attempt to send the alert without having a valid address to send it to.

Affected services
Which resource within the processing framework does this affect?

  • All of them

To Reproduce
Steps to reproduce the behavior:

  1. Modify procfwk.PipelineAlertLink to setup a worker pipeline to alert an email address only when an error occurs (OutcomesBitValue = 4). Ensure no other alerts are configured for the pipeline
  2. Run the framework to process the pipeline successfully
  3. In the ADF monitor view, the framework child pipeline will have a status of error from trying to send an email to a blank address

Expected behaviour
The framework should be checking the outcome of the worker pipeline to determine if there are any alerts to be sent based a bit-wise AND with procfwk.PipelineAlertLink.OutcomesBitValue.

Additional context
I have a branch on my fork with a fix, will submit a PR with the details

@NJLangley NJLangley added the bug Something isn't working label Jul 21, 2020
@mrpaulandrew mrpaulandrew linked a pull request Jul 22, 2020 that will close this issue
Framework Internal Backlog automation moved this from In progress to Released Jul 22, 2020
mrpaulandrew added a commit that referenced this issue Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants