Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize merging list of nodes #5

Open
mrroman opened this issue Sep 6, 2016 · 0 comments
Open

Optimize merging list of nodes #5

mrroman opened this issue Sep 6, 2016 · 0 comments

Comments

@mrroman
Copy link
Owner

mrroman commented Sep 6, 2016

Currently merger procedure:

  1. Checks if number of child nodes is the same as number of views. If there are more views it creates new one(s).
  2. Goes through the list and if the child node's connected view is different than merged view, it recreates it completely.

It is wrong because when someone adds view at the top of the list, child nodes are all rewritten nevertheless their views weren't changed. We can optimize it like React does it by adding key property to El and use it to merge child nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant