Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do ARM64 builds #13

Open
mrsimonemms opened this issue Jun 26, 2023 · 4 comments · Fixed by #14
Open

Do ARM64 builds #13

mrsimonemms opened this issue Jun 26, 2023 · 4 comments · Fixed by #14
Labels
enhancement New feature or request

Comments

@mrsimonemms
Copy link
Owner

mrsimonemms commented Jun 26, 2023

Is your feature request related to a problem? Please describe

Create an ARM64 version of the image so that Macs are supported natively.

Describe the behaviour you'd like

Add linux/arm64 to the platform options in the build. For speed, this should only be on builds on the main branch - anything built on any other branch should just build the linux/amd64 image only.

Describe alternatives you've considered

Additional context

Discussion

@mrsimonemms mrsimonemms added the enhancement New feature or request label Jun 26, 2023
mrsimonemms referenced this issue in mrsimonemms/devpod-provider-hetzner Jun 27, 2023
@bgervan
Copy link

bgervan commented Jun 27, 2023

Multiarch is not supported
https://github.com/bgervan/devcontainers/actions/runs/5370629981/jobs/9742844492

[2023-06-25T15:58:46.487Z] Start: Run: docker buildx build --platform linux/amd64,linux/arm64 --load --build-arg BUILDKIT_INLINE_CACHE=1 -f /tmp/devcontainercli-runner/container-features/0.46.0-1687708726473/Dockerfile-with-features -t ghcr.io/bgervan/devcontainers/base:2023-06-25 -t ghcr.io/bgervan/devcontainers/base:latest --target dev_containers_target_stage --build-arg _DEV_CONTAINERS_BASE_IMAGE=dev_container_auto_added_stage_label /home/runner/work/devcontainers/devcontainers/base/.devcontainer [2023-06-25T15:58:46.667Z] ERROR: docker exporter does not currently support exporting manifest lists

But maybe there are solutions, didn't check yet

@bgervan
Copy link

bgervan commented Jun 27, 2023

@mrsimonemms
Copy link
Owner Author

I think I fixed it by playing with the devcontainer commands and adding the --push command. It's built as a multiarch image, so the docker pull command will be the same for both AMD64 and ARM64

@mrsimonemms mrsimonemms reopened this Jun 28, 2023
@shyim
Copy link

shyim commented Jul 3, 2023

I can recommend https://buildjet.com/for-github-actions and then splitting into two jobs and merging it in one job afterwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants