Downgrade ActiveSupport dependency to >= 6.1 #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeko369
approved these changes
Jun 26, 2023
|
I'd rather not go down this path, because MRSK needn't be added to the application's Gemfile, so there's no demand for compatibility. Maybe we need to document this better. We've been using MRSK with Rails 2.3 applications! Install mrsk as a global, then you're good to go. Please do have a look at what tweaks we need to the docs to make this clearer. |
|
Good point, will work on documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I propose downgrading the ActiveSupport dependency in MRSK to a minimum version of 6.1. Since no ActiveSupport 7.0 methods are utilized in MRSK, this change allows for broader compatibility with Rails 6 applications.
By supporting the current Rails version as well as the previous one, MRSK becomes an even more widely used deployment tool.