Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolving missing process.env in v5 #267

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Conversation

mrsteele
Copy link
Owner

@mrsteele mrsteele commented Nov 3, 2020

Alright, second time approaching this one.

I have to do some more digging, but webpack may have resolved something since my last attempt. Things are populating appropriately again in the bundles and I didn't change really anything.

Would love some more eyes on this just to see if I am missing anything.

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #267 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   98.69%   98.70%   +0.01%     
==========================================
  Files           2        2              
  Lines         153      155       +2     
  Branches       38       38              
==========================================
+ Hits          151      153       +2     
  Misses          2        2              
Impacted Files Coverage Δ
src/index.js 98.38% <100.00%> (+0.02%) ⬆️
index.js 98.92% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd5e406...2a6bc20. Read the comment docs.

@mrsteele mrsteele mentioned this pull request Nov 6, 2020
@mrsteele mrsteele merged commit 3ecc1e0 into master Nov 6, 2020
@mrsteele mrsteele deleted the feature/fixMissingIssue branch November 6, 2020 13:57
@mrsteele
Copy link
Owner Author

mrsteele commented Nov 6, 2020

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

tobias-trozowski pushed a commit to tobias-trozowski/dotenv-webpack that referenced this pull request Nov 12, 2020
* feat: resolving missing process.env in v5

* chore: resolving tests

Co-authored-by: Matt Steele <hello@mrsteele.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant