Redirects to other pages are sometimes included in the Lua table

[mrstradivarius]

When fetching redirects to a template, sometimes redirects to different pages are being included. This results in those redirects being included in the Lua table.

See, for example, line 75 of Module:Pagetype/softredirect/sandbox. This template, Template:Taxonomy/Olindiasidae, is a redirect, but it does not redirect to Template:Soft redirect with Wikidata item; it only links to it.

[mrstradivarius]

This is caused by dablinks.py using BasePage.backlinks on line 45. This method lists all links, not just redirects. While dablinks.py uses the filter_redirects option to this method to return only redirects, this does not ensure that the redirect target is the desired page; pages that are redirects to other targets are also included if they link to or transclude the desired page in the redirect body. The correct method to use is the BasePage.redirects method; this method will only return redirects where the target is the desired page.