Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang-format support #107

Open
drodil opened this issue Oct 2, 2018 · 4 comments
Open

Clang-format support #107

drodil opened this issue Oct 2, 2018 · 4 comments
Milestone

Comments

@drodil
Copy link
Contributor

drodil commented Oct 2, 2018

In order to have the code formatting generalized, I would suggest adding .clang-format configuration file in the project and mention using of clang-format in the contribution guidelines.

More information here: https://clang.llvm.org/docs/ClangFormat.html

@mrtazz
Copy link
Owner

mrtazz commented Oct 31, 2018

we are currently using cpplint for maintaining a standardized format. What would clang-format give us over cpplint? I'm not opposed to changing it but would like to understand the advantages.

@mrtazz
Copy link
Owner

mrtazz commented Feb 12, 2020

Thank you @sineang01! This sounds like a reasonable set of advantages. If you're willing to open a PR to replace cpplint with clang-format, I'd be happy to review and merge it. Otherwise it might happen when I find the time to get to it.

@mrtazz mrtazz added this to the v0.6.0 milestone May 4, 2020
@edwinpjacques
Copy link
Contributor

@drodil I like this idea, would you be able to make a PR for it? Should be pretty easy, no?

@drodil
Copy link
Contributor Author

drodil commented Oct 30, 2020

Wow 2y later 😃 Not sure I have time any time soon but I'll keep it in mind!

@offa offa mentioned this issue May 21, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants