Skip to content

Commit

Permalink
libhidpp: hidpp20: Change LogitechInternal error to NotAllowed
Browse files Browse the repository at this point in the history
There has been some confusion about error value 5 but feature specs that refer
to it generally use NOT_ALLOWED.

Deprecate the LogitechInternal identifier but keep it around for now.
  • Loading branch information
Martin Rubli committed Mar 14, 2023
1 parent 0ca96e5 commit 80c3fec
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/libhidpp/hidpp20/Error.cpp
Expand Up @@ -45,8 +45,8 @@ const char *Error::what () const noexcept
return "Out of range";
case HWError:
return "Hardware error";
case LogitechInternal:
return "Logitech internal";
case NotAllowed:
return "Not allowed";
case InvalidFeatureIndex:
return "Invalid feature index";
case InvalidFunctionID:
Expand Down
3 changes: 2 additions & 1 deletion src/libhidpp/hidpp20/Error.h
Expand Up @@ -36,7 +36,8 @@ class Error: public std::exception
InvalidArgument = 2,
OutOfRange = 3,
HWError = 4,
LogitechInternal = 5,
NotAllowed = 5,
LogitechInternal [[deprecated]] = NotAllowed,
InvalidFeatureIndex = 6,
InvalidFunctionID = 7,
Busy = 8,
Expand Down

0 comments on commit 80c3fec

Please sign in to comment.