Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RefCell from Class and Module specs #4543

Closed
lopopolo opened this issue Jun 29, 2019 · 1 comment
Closed

Remove RefCell from Class and Module specs #4543

lopopolo opened this issue Jun 29, 2019 · 1 comment

Comments

@lopopolo
Copy link
Contributor

Just make Define mutable and store the RClass. In ClassLike::rclass, short circuit if rclass is Some and resolve the RClass using the mruby C API. Don't store this result to keep the API simple and not require mutability.
@lopopolo
Copy link
Contributor Author

Oops I didn't meant to file this here. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lopopolo